Fix: SFDP conformance checks #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… table based on its version number
…le validation fires and has to correct the data
…llow it to write the raw data out to console
… the SFDP data from a device
…s not directly included
…Timing_t::pageSize()`
…ssing information
…nularity information
dragonmux
added
Bug
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 34 34
Lines 1737 1812 +75
Branches 549 562 +13
=====================================
- Misses 1692 1781 +89
+ Partials 45 31 -14 ☔ View full report in Codecov by Sentry. |
…n without the opcode being passed along
dragonmux
force-pushed
the
fix/sfdp-conformance-checks
branch
from
6083979 to
d306d26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue found and reported by ALTracer on Discord where some devices report mismatching length and SFDP Basic Parameter Table version information. It was determined in the process that the length information is in fact correct and should be trusted in place of the version information when a conflict occurs and the length is shorter than it is expected to be, and the version trusted otherwise.
This PR implements new checks to verify the length information against the version information and correct whichever one is wrong, warning the user that this has had to happen in the process.
Additionally, this PR fixes a problem we spotted with the SPI Flash write process due to the sector erase opcode never being or'd in to the command sent. This would have meant that writes would only work with already empty devices.